Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify info view headers #59

Merged
merged 7 commits into from May 2, 2016
Merged

Modify info view headers #59

merged 7 commits into from May 2, 2016

Conversation

ZachOrr
Copy link
Member

@ZachOrr ZachOrr commented May 2, 2016

Looking for feedback - might need to take another pass at how the Team view looks since there's more info there. But I think the Event view is pretty good.
simulator screen shot may 2 2016 1 11 22 pm
simulator screen shot may 2 2016 1 11 27 pm

@ZachOrr
Copy link
Member Author

ZachOrr commented May 2, 2016

Gonna merge this - hopefully we can find a way to bring back in the sponsors at some point

@ZachOrr ZachOrr merged commit 30fd383 into master May 2, 2016
@ZachOrr ZachOrr deleted the modify-info-view-headers branch May 2, 2016 23:19
@brandondean
Copy link
Member

Seems reasonable to me. Maybe another section underneath the name for the sponsors? It'll visually disconnect it, keeping the nickname obvious, but it might push down the social section just a bit too far.

@ZachOrr
Copy link
Member Author

ZachOrr commented May 2, 2016

Another section might be a good call. I thought about making it another cell in the first section. Or even throwing a cell underneath the team info header with the title "Sponsors" and a disclosure indicator. I don't know how interesting sponsors are to most people, and it does take up quite a bit of screen real estate.

@brandondean
Copy link
Member

simulator screen shot may 2 2016 19 37 46 pm

@brandondean
Copy link
Member

Meh. Could shrink it like android does. Limiting it to 2 lines, and then expanding it on tap.

@ZachOrr
Copy link
Member Author

ZachOrr commented May 2, 2016

I'd be okay with that. Expanding cells are a little weird, but in a lot of cases sponsors are just going to be a big wall of text. So any way of hiding it is probably a good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants