Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Legacy Builtin NDB Library #4018

Merged
merged 2 commits into from Nov 26, 2021

Conversation

phil-lopreiato
Copy link
Member

@phil-lopreiato phil-lopreiato commented Nov 26, 2021

Towards #3995

This will simplify a few things, mainly the fact we can just have native interop between old/new apps without having to do a bunch of hackery to get datastore seriliazation/memcache to agree on a data format.

The couple things still remaining:

  • figure out if we can still use the remote api locally. Answer: no, because adding googledatastore creates dependency hell. We can file an upstream issue for this.
  • update docs

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #4018 (1827c40) into py3 (58e9f6c) will increase coverage by 0.58%.
The diff coverage is 99.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              py3    #4018      +/-   ##
==========================================
+ Coverage   93.05%   93.63%   +0.58%     
==========================================
  Files         422      418       -4     
  Lines       22715    21613    -1102     
  Branches       60       60              
==========================================
- Hits        21137    20237     -900     
+ Misses       1570     1368     -202     
  Partials        8        8              
Impacted Files Coverage Δ
src/backend/common/logging.py 63.63% <0.00%> (ø)
...pi/handlers/helpers/tests/model_properties_test.py 100.00% <100.00%> (ø)
...backend/api/handlers/tests/add_match_video_test.py 100.00% <100.00%> (ø)
src/backend/api/handlers/tests/apiv3_auth_test.py 100.00% <100.00%> (ø)
src/backend/api/handlers/tests/cors_test.py 100.00% <100.00%> (ø)
src/backend/api/handlers/tests/event_test.py 100.00% <100.00%> (ø)
src/backend/api/handlers/tests/status_test.py 100.00% <100.00%> (ø)
src/backend/api/handlers/tests/team_test.py 100.00% <100.00%> (ø)
...backend/api/handlers/tests/trustedapi_auth_test.py 100.00% <100.00%> (ø)
...rc/backend/api/handlers/tests/update_teams_test.py 100.00% <100.00%> (ø)
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e9f6c...1827c40. Read the comment docs.

@phil-lopreiato phil-lopreiato marked this pull request as ready for review November 26, 2021 19:36
@phil-lopreiato phil-lopreiato changed the title use ndb builtin lib Migrate to Legacy Builtin NDB Library Nov 26, 2021
@phil-lopreiato phil-lopreiato merged commit 707e9b7 into the-blue-alliance:py3 Nov 26, 2021
@phil-lopreiato phil-lopreiato deleted the builtin-ndb branch November 26, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants