Fix all issues reported by Pareon Verify

[kaa-ching]

Pareon Verify is a dynamic application analyzer (similar to Valgrind) that I happen to know very intimately.

The tool currently reports a few errors that really need fixing - most of these issues will cause crashes.

[kaa-ching]

git commit [7a260d0] and a few before help to achieve this goal by making the code more friendly towards Pareon Verify. For now, the only issue fixed is e2aa296.

[kaa-ching]

Found this one:

===== PAREON VERIFY =====
[M0443] Array bound violation(s) detected:
  the write in
    function ViewPingus::ViewPingus(std::shared_ptr<AbstractObject>) at tbe-github/src/view/ViewPingus.cpp:50
    called from function Pingus::createViewObject(float) at tbe-github/src/model/Pingus.cpp:271
    called from function World::addAbstractObjectToViewWorld(std::shared_ptr<AbstractObject>) at tbe-github/src/model/World.cpp:126
    called from function World::createScene(ResizingGraphicsView*) at tbe-github/src/model/World.cpp:205
    called from function MainWindow::loadLevel(QString const&) at tbe-github/src/view/MainWindow.cpp:109
    called from function MainWindow::loadLevelDelayed() at tbe-github/src/view/MainWindow.cpp:118
    called from function MainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) at tbe-github/build/src/view/moc_MainWindow.cxx:175
    called from unanalyzed function QApplication::exec()
    called from function main at tbe-github/src/main.cpp:315
    ^^^ application start ^^^
  performed 9 access(es) of size 4 at an offset of 292 bytes from the start of
  the heap object of size 296 allocated through a call to `operator new(unsigned long)' in
    function Pingus::createViewObject(float) at tbe-github/src/model/Pingus.cpp:271
    called from function World::addAbstractObjectToViewWorld(std::shared_ptr<AbstractObject>) at tbe-github/src/model/World.cpp:126
    called from function World::createScene(ResizingGraphicsView*) at tbe-github/src/model/World.cpp:205
    called from function MainWindow::loadLevel(QString const&) at tbe-github/src/view/MainWindow.cpp:109
    called from function MainWindow::loadLevelDelayed() at tbe-github/src/view/MainWindow.cpp:118
    called from function MainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) at tbe-github/build/src/view/moc_MainWindow.cxx:175
    called from unanalyzed function QApplication::exec()
    called from function main at tbe-github/src/main.cpp:315
    ^^^ application start ^^^
  where array index 7 is outside of array `.field2[0..6]' in
    function ViewPingus::ViewPingus(std::shared_ptr<AbstractObject>) at tbe-github/src/view/ViewPingus.cpp:50
    called from function Pingus::createViewObject(float) at tbe-github/src/model/Pingus.cpp:271
    called from function World::addAbstractObjectToViewWorld(std::shared_ptr<AbstractObject>) at tbe-github/src/model/World.cpp:126
    called from function World::createScene(ResizingGraphicsView*) at tbe-github/src/model/World.cpp:205
    called from function MainWindow::loadLevel(QString const&) at tbe-github/src/view/MainWindow.cpp:109
    called from function MainWindow::loadLevelDelayed() at tbe-github/src/view/MainWindow.cpp:118
    called from function MainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) at tbe-github/build/src/view/moc_MainWindow.cxx:175
    called from unanalyzed function QApplication::exec()
    called from function main at tbe-github/src/main.cpp:315
    ^^^ application start ^^^


1 error(s)

[kaa-ching]

When deleting and undoing delete in picnic-0:

**   t=162: UndoSingleton::push for 'Remove Quarter Arc Large'
**   t=162: InsertUndoCommand::undo for 'Remove Quarter Arc Large'
**   t=162: AbstractUndoCommand::undo for 'Remove Quarter Arc Large'
*    t=162: setNewGeometry Pos: (4.70475,2.7315)@1.94855, WxH 0.8x0.8
**   t=165: InsertUndoCommand::redo for 'Remove Quarter Arc Large'
WARNING: Process 28894 caught terminating signal 11 (Segmentation fault).
Segmentation fault (core dumped)
klaas@x230:~/Programming/tbe-github$ ===== PAREON VERIFY =====
[M0224] Segmentation-violation signal delivered to unanalyzed function `QGraphicsItem::setVisible(bool)' called in
    function InsertUndoCommand::redo() at /home/klaas/Programming/tbe-github/src/control/InsertUndoCommand.cpp:134
    called from function DeleteUndoCommand::undo() at /home/klaas/Programming/tbe-github/src/control/DeleteUndoCommand.cpp:56
    called from unanalyzed function QApplication::exec()
    called from function main at /home/klaas/Programming/tbe-github/src/main.cpp:323
    ^^^ application start ^^^

1 error(s)

[kaa-ching]

Looks like TBE is rather crash-free. Yay!