Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No picture for Cola+mint Bottle #44

Closed
glixx opened this issue Oct 20, 2015 · 12 comments
Closed

No picture for Cola+mint Bottle #44

glixx opened this issue Oct 20, 2015 · 12 comments
Assignees
@kaa-ching
Labels
bug
Milestone
Milestone A

Comments

@glixx
Copy link
Member

glixx commented Oct 20, 2015

elce09/005.xml: no picture for "Cola+mint Bottle"

a8
@kaa-ching
Copy link
Member

I'm pretty sure your tree is out-of-sync if this happens...
Will check tomorrow!

@glixx
Copy link
Member Author

glixx commented Oct 20, 2015

Pictures should be on the left side. Else if string is big, then no picture.

@kaa-ching
Copy link
Member

It looks ugly if I align left, but it beats the alternative.

kaa-ching added a commit that referenced this issue Oct 20, 2015
@kaa-ching
Align text left to keep toolboxitem icon visible, issue #44
f08d8d0
@kaa-ching
Copy link
Member

Does this help?

@kaa-ching kaa-ching self-assigned this Oct 20, 2015
@kaa-ching kaa-ching added the bug label Oct 20, 2015
@kaa-ching kaa-ching added this to the Milestone A milestone Oct 20, 2015
@kaa-ching
Copy link
Member

This is a regression from the fix for issue #41.

@glixx
Copy link
Member Author

glixx commented Oct 20, 2015

Text looks better, but issue is present for picture again.

@kaa-ching
Copy link
Member

Is this better? 😃
toolbox-wrapped

@glixx
Copy link
Member Author

glixx commented Oct 21, 2015

Yes, but I don't see this in ee03cda

@kaa-ching
Copy link
Member

Relax, I'm trying to make it even better!

@kaa-ching
Copy link
Member

And this is what I'm going to settle at. Let's hope no-one needs 5 lines...
even-better

kaa-ching added a commit that referenced this issue Oct 21, 2015
@kaa-ching
solving issue #44, let's hope no item name will ever span 5 lines
ce27dd2
@kaa-ching
Copy link
Member

BTW, I just realized you translated as Coca-Cola and Mentos. I deliberately did not use brand names in the English version...

@kaa-ching kaa-ching reopened this Oct 21, 2015
@kaa-ching
Copy link
Member

not for this release 😛

@the-butterfly-effect the-butterfly-effect locked and limited conversation to collaborators Oct 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kaa-ching kaa-ching

Labels
bug
Projects
None yet
Milestone
Milestone A
Development

No branches or pull requests
2 participants
@glixx @kaa-ching