Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path options for cmake #49

Closed
glixx opened this issue Oct 30, 2015 · 5 comments
Closed

Add path options for cmake #49

glixx opened this issue Oct 30, 2015 · 5 comments

Comments

@glixx
Copy link
Member

glixx commented Oct 30, 2015

Needs to add cmake options for gamesbindir, gamesdatadir.
Maintainers of Fedora, Arch Linux do not like the current implementation.

@kaa-ching
Copy link
Member

I agree, would work better for the Windows and self-extracting archive packages, too.

The current directory set appears to be just fine for Ubuntu and Mageia.

The variables are already defined in the CMakeLists.txt file, so:

  • we need a mechanism to overrule the set variables or at least differentiate
  • we need a mechanism to make sure that TBE knows more about the file locations, i.e. generate tbe_paths.h from the settings.
  • we need to know what the various paths for the various distros look like.

@kaa-ching
Copy link
Member

@glixx: can you help to figure out what the Fedora and ALT packagers want for a directory layout?

@glixx
Copy link
Member Author

glixx commented Nov 1, 2015

For Mageia, Debian, Alt Linux:
gamesbindir=/usr/games
gamesdatadir=/usr/share/games

For Fedora, Arch Linux:
gamesbindir=/usr/bin
gamesdatadir=/usr/share

@kaa-ching
Copy link
Member

@glixx: thanks for the info, this will be enough to make it work.

kaa-ching added a commit that referenced this issue Dec 28, 2015
Generate the search paths from Cmake.
This will also help with Linux builds (issue #49 and issue #48).
@kaa-ching kaa-ching changed the title And path options for cmake Add path options for cmake Jan 6, 2016
@kaa-ching
Copy link
Member

I expect this issue to be closed because we can now adjust the installation paths to all directories during package build.

@the-butterfly-effect the-butterfly-effect locked and limited conversation to collaborators May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants