-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Chakra UI To List and ListItem Components #42
Conversation
Visit the preview URL for this PR (updated for commit efd86d5): https://tcl-55-smart-shopping-list--pr42-yj-ky-list-item-chak-coq3e9rm.web.app (expires Sun, 04 Jun 2023 23:04:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 607d14028385ebfcc7c9ec69a7bb14d95ed54078 |
…b-lab/tcl-55-smart-shopping-list into yj-ky-list-item-chakra
…b-lab/tcl-55-smart-shopping-list into yj-ky-list-item-chakra
It's looking great!
For future consideration:
|
After messing around with the code with Ticia I think we came up with with a nice solution for the Tabs overflowing. If you try the code in this gist then just the Tab titles should scroll and all of the details from the TabPanel should fit without overflowing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is functional, and the tab highlighting looks great! I think the whole page is looking good besides the padding and scroll on smaller screens, but Jeremiah and I looked at it and he came up with a great solution that I think resolves those issues.
For an example of how to fill this template out, see this Pull Request.
Description
This code changes the styling structure of all of the
List
andListItem
components by using chakra UI components. It also adds a new component,Dialog
, to replace the window.confirm dialog. This code also adds a new display for the user's current token and the ability to quickly copy the token.Link to the design wireframe: https://www.figma.com/file/4oxU5wehZPNinZpr24UuLw/Chakra-UI-Figma-Kit-(Community)?type=design&node-id=2102-2110&t=ciT6mhpJqrDlx0bY-0
Related Issue
Closes #34
Closes #35
Acceptance Criteria
Issue 16.
/list
, the current token should be displayed along with a graphic to copy the token on click (Asset:CkCopy
chakra icon)Search
input field should include anx
to clear the search filter. (Asset:InputRightElement
withCkClose
chakra icon)dialog
should be styled using a chakratoast
component at the top of the page [tbd]Issue 17.
ListItemDetails.jsx
(chakra asset:AccordionButton
)x
icon (chakra asset:InputRightElement
withCkClose
chakra icon) will display in the accordion button and perform theonClick
delete functionalityallowMultiple
)AlertDialog
component instead of window.confirmType of Changes
Updates
Before
After
Testing Steps / QA Criteria
In your terminal, use
git checkout yj-ky-list-item-chakra
to create a new branch and switch over.Use
git pull origin yj-ky-list-item-chakra
to bring the changes from remote to local.npm start
to start a local instance of our appCopy
icon next to the List token name and paste it somewhere to make sure the list is copied correctly onto the clipboard.Filter Items
input field, the list on whatever tab you're on should update along with all other tabs if you click through each category.X
after your search, the lists should go back to the original items in each category and the input field should go back to the placeholder.Cancel
will bring you back, selectingDelete
will delete the item in firebase, remove it from the list, and aToast
should pop up if successful