Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Chakra UI components to the Home page #45

Merged
merged 8 commits into from
May 28, 2023
Merged

Conversation

jeremiahfallin
Copy link
Collaborator

@jeremiahfallin jeremiahfallin commented May 26, 2023

Description

This code adds styling using Chakra components to the home page. Some parts of the styling are based on the viewport size (larger elements on desktop). Functionality is retained from previous version of page.

Related Issue

Closes #39

Acceptance Criteria

  • List Luxe should be our title, styled using Playfair (bold)
  • Create New List and Join buttons are Chakra button components stylized using Ysabeau (bold) with a Chakra divider UI component separating them
    • Both buttons should function as expected per previous issues
  • The list input should be implemented using the Chakra input component and allows clearing only if there is input in the field
  • The gif on the bottom should load and animate correctly after page loads
  • Error messages should be displayed using chakra toast component

Type of Changes

Type
✨ New feature
🔨 Refactoring
🔗 Update dependencies

Updates

Before

image

After

image

Testing Steps / QA Criteria

  • In your terminal, use git checkout tf-jf-about drawer to create a new branch and switch over.
  • Use git pull origin tf-jf-about drawer to bring the changes from remote to local.
    • npm install may need to be used to add the feather-icons-react package.
  • Clear any list token in local storage to be directed to the Home page.
  • npm start to start a local instance of our app.

@github-actions
Copy link

github-actions bot commented May 26, 2023

Visit the preview URL for this PR (updated for commit af53260):

https://tcl-55-smart-shopping-list--pr45-tf-jf-home-page-styl-gz1a73jp.web.app

(expires Sun, 04 Jun 2023 20:27:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 607d14028385ebfcc7c9ec69a7bb14d95ed54078

@jeremiahfallin jeremiahfallin changed the title Tf jf home page styling Adds Chakra UI components to the Home page May 26, 2023
@jeremiahfallin jeremiahfallin marked this pull request as ready for review May 27, 2023 01:56
Copy link
Collaborator

@Yaosaur Yaosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on mobile view, we need to do some clean up for the desktop view. Main issues is missing create a new list button and gif being too large. Other than that, everything else looks fine. Minor suggestions on heading and open item for discussion on toast message. Thanks for working on this, Ticia and Jeremiah!

src/views/Home.jsx Outdated Show resolved Hide resolved
src/views/Home.jsx Outdated Show resolved Hide resolved
src/views/Home.jsx Show resolved Hide resolved
src/views/Layout.jsx Show resolved Hide resolved
src/views/Home.jsx Outdated Show resolved Hide resolved
@Yaosaur Yaosaur merged commit 3fdafc5 into main May 28, 2023
2 checks passed
@Yaosaur Yaosaur deleted the tf-jf-home-page-styling branch May 28, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20. As a user, I want to be greeted with a professional home page implemented with Chakra UI
3 participants