-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Chakra UI components to the Home page #45
Conversation
Visit the preview URL for this PR (updated for commit af53260): https://tcl-55-smart-shopping-list--pr45-tf-jf-home-page-styl-gz1a73jp.web.app (expires Sun, 04 Jun 2023 20:27:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 607d14028385ebfcc7c9ec69a7bb14d95ed54078 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on mobile view, we need to do some clean up for the desktop view. Main issues is missing create a new list button and gif being too large. Other than that, everything else looks fine. Minor suggestions on heading and open item for discussion on toast message. Thanks for working on this, Ticia and Jeremiah!
Description
This code adds styling using Chakra components to the home page. Some parts of the styling are based on the viewport size (larger elements on desktop). Functionality is retained from previous version of page.
Related Issue
Closes #39
Acceptance Criteria
toast
componentType of Changes
Updates
Before
After
Testing Steps / QA Criteria
git checkout tf-jf-about drawer
to create a new branch and switch over.git pull origin tf-jf-about drawer
to bring the changes from remote to local.npm install
may need to be used to add thefeather-icons-react
package.npm start
to start a local instance of our app.