Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style the basic page layout that applies to all views of the app using components from MUI Library #34

Merged
merged 8 commits into from
May 24, 2023

Conversation

Amy-Pr
Copy link
Collaborator

@Amy-Pr Amy-Pr commented May 20, 2023

Description

This PR styles the layout of the app using MUI. The Navigation and Header area are separated from the main body of the app using MUI Container layout components. The containers are given a flex display attribute to center the content. Note: Containers are given color attributes for visualization purposes only and will change as customization decisions are made later in development.

Related Issue

Type of Changes

Type
πŸ› Bug fix
βœ“ ✨ New feature
πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

Before this PR, the navigation links show up at the bottom of the UI, and basic layout is controlled by layout.css

After

After this PR, the page is broken into different MUI Container components and an App Bar for headline and navigation is set at the top of the page.

Testing Steps / QA Criteria

-Check out the links on the nav bar and spacing of main content.

@github-actions
Copy link

github-actions bot commented May 20, 2023

Visit the preview URL for this PR (updated for commit 1269e1c):

https://tcl-57-smart-shopping-list--pr34-ap-mui-app-layout-sc6ka69b.web.app

(expires Wed, 31 May 2023 05:58:50 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb

@Amy-Pr Amy-Pr marked this pull request as ready for review May 24, 2023 21:13
@Amy-Pr Amy-Pr merged commit 0453489 into main May 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants