Fix height of container in List page. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e5a4e1e): https://tcl-57-smart-shopping-list--pr45-jg-fix-list-page-hei-ou5mfjcb.web.app (expires Thu, 01 Jun 2023 04:34:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb |
Amy-Pr
reviewed
May 25, 2023
| @@ -86,7 +87,7 @@ export function List({ data, listToken }) { | |||
| } | |||
|
|
|||
| return ( | |||
| <> | |||
| <Box minHeight="100vh"> | |||
There was a problem hiding this comment.
Cool! So this wasn't a container issue in Layout.jsx? I was wondering why all the other pages were fine now and not this page.
There was a problem hiding this comment.
Aha! Nice fix, @jongranados!
emilysellers
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The List page did not extend to the height of the viewport when the user's list did not fill the entire screen (when their list was empty or when their list was short).
Related Issue
Closes #42
Acceptance Criteria
Type of Changes
Updates
Before
After