-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon Menu Positioned on App Bar for Mobile/Small-Screen View #56
Conversation
Visit the preview URL for this PR (updated for commit ee837d0): https://tcl-57-smart-shopping-list--pr56-ap-feature-navbar-me-efspx0f9.web.app (expires Sun, 04 Jun 2023 03:10:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb |
src/views/Layout.jsx
Outdated
)} | ||
|
||
{/* This is the title displayed on the left for medium to large screen sizes */} | ||
<BreakfastDiningOutlinedIcon sx={{ mr: 1 }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the toast icon adds some fun character but could also be a bit misleading to the user as it kind of resembles a button or some kind of interactive element. I think the nav bar might be stronger without it. Just my two cents!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @Amy-Pr! This is working as expected and provides a much cleaner nav bar on smaller screens. In answer to your question, I think the App Bar could be refactored into its own component, but it's also fine as is.
Description
This PR implements an interactive icon on the App Bar containing the Nav Links for small screen sizes. Uses styling from "App Bar with Responsive Menu" MUI component. https://mui.com/material-ui/react-app-bar/
Question to team: Should the App Bar be its own component, as the code takes up a good 90% of the Layout.jsx?
Related Issue
Closes #39
Acceptance Criteria
Type of Changes
Updates
New menu icon and toast icon. Refactored ternary operator for the hiding the links when there is no list token. Used MUI Components instead of empty
div
elements, since thediv
elements interfered with responsive behavior.Testing Steps / QA Criteria