Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship edit-add #4017

Merged
merged 10 commits into from
May 31, 2019
Merged

Relationship edit-add #4017

merged 10 commits into from
May 31, 2019

Conversation

grimxd
Copy link
Contributor

@grimxd grimxd commented Mar 20, 2019 •
edited by emptynick
Loading

Fixes #4003

@grimxd grimxd closed this Mar 20, 2019
@grimxd grimxd reopened this Mar 20, 2019
@grimxd grimxd changed the title Test Relationship edit-add Mar 20, 2019
@emptynick emptynick removed the invalid label Mar 20, 2019
@fletch3555
Copy link
Collaborator

@grimxd, we need more information when opening pull requests. If it's related to an open issue, a link to the issue is fine, but ideally you should describe what you're changing and the reasoning/justification behind the change

@emptynick
Copy link
Collaborator

If you untick edit for a relationship and go to the add-page for that BREAD the relationship does not show any results, because the controller only looks for the editRows.
This PR changes this to be depending on the current action.

@emptynick emptynick merged commit 26cf624 into thedevdojo:1.2 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emptynick emptynick emptynick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] If you untick edit for the relationships in BREAD, the row does not exists
3 participants
@grimxd @fletch3555 @emptynick