Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for eval usage #4

Closed
ryun opened this issue Oct 28, 2016 · 3 comments
Closed

Suggestion for eval usage #4

ryun opened this issue Oct 28, 2016 · 3 comments

Comments

@ryun
Copy link

ryun commented Oct 28, 2016

On thing that caught my eye while browsing the code was the usage of eval in the BreadController.
I'm sure there are other options, but you may instantiate the classes with:

$dataTypeContent = (new $dataType->model_name)->find($id);
@tnylea
Copy link
Collaborator

tnylea commented Oct 30, 2016

Thanks for the suggestion. I'll do some testing and then add this functionality in there if all is working well. I'll keep you posted.

Thanks again!

@marktopper
Copy link
Contributor

Seems to be fixed.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants