Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/278/enroll splash section #286

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

rbrodefrank
Copy link
Collaborator

@rbrodefrank rbrodefrank commented Nov 1, 2019

Issue: #278

Describe the problem being solved:

Made changes to the carousel.

Before:
feature-278-before

After:
feature-278-after

Impacted areas in the application:

Enroll Page, Single Carousel

List general components of the application that this PR will affect:

  • /frontend/src/components/enroll/index.js
  • /frontend/src/components/SingleCarousel/index.jsx

PR checklist

  • I included a screenshot for FE changes
  • I have linked the PR to a Zenhub ticket
  • I have checked for merge conflicts
  • I have run the prettier command make pretty

@mkarazin mkarazin added the CR: Needs Review Indicates the pull request is ready for review label Nov 1, 2019
@mkarazin mkarazin added CR: Approved Indicates the pull request is approved and removed CR: Needs Review Indicates the pull request is ready for review labels Nov 1, 2019
@mkarazin mkarazin merged commit d481d76 into staging Nov 1, 2019
@dkaplan88 dkaplan88 deleted the feature/278/enroll-splash-section branch April 2, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR: Approved Indicates the pull request is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants