Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sqlite #175

Merged

Conversation

samuelgrant
Copy link
Contributor

@samuelgrant samuelgrant commented Oct 31, 2022

After discussions with Lia, Reoze, Lyari and myself we have decided to remove SQLite from the project. This means contributors will only have to write MySQL-compatible SQL queries and we won't have to maintain two sets of migrations.

Going forward developers will need to ensure they have MySQL installed. If you don't know how to install MySQL you can follow this Digital Ocean | How to Install MySQL on Ubuntu guide.

Once you have MySQL installed you will need to log in and create a database.

mysql -u root -p
create database waitlist;
use waitlist;

# Run the mysql.sql script here

exit;

You will need to update your config.toml file, and when you use the CLI to build the backend you will need to use these environment variables mysql (instead of sqlite) and the database URL:

mysql://<database_username>:<and_password>@localhost/waitlist?ssl-mode=disabled`

If you have any questions about migrating your local development environment, flick me a message.


Issues:

  • Dockerfile broken #176 our Dockerfile will be broken by this PR. While I don't believe we're making use of it right now, I decided not to remove it because I see value in using Docker for deployment in the future. Keeping the file in source gives us an easy reference point if we choose to provide support for Docker, GH Actions and GHCR in the future.

  • sqlite is still used for SDE-related stuff. I decided not to change this as it would require significantly more work. This PR will still make development considerably easier.

@samuelgrant samuelgrant mentioned this pull request Oct 31, 2022
@samuelgrant samuelgrant marked this pull request as ready for review November 21, 2022 08:43
The image needs to be updated - this will happen later as I don't have the tools so I will need to seek help from someone else.
@samuelgrant
Copy link
Contributor Author

I accidentally pushed today's work onto this branch. Here is the tldr;
• Added a show info button on the profile page
• List alts on the profile page
• Teamspeak button now adds ?username
• Updated drone terms in newbro guide

@luna-duclos luna-duclos merged commit 0d71578 into the-ditanian-fleet:main Nov 25, 2022
@samuelgrant samuelgrant deleted the feature/remove-sqlite branch November 25, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants