Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Ordering of SASLMechanisms #423

Merged
merged 1 commit into from
May 30, 2022

Conversation

geraldurbas
Copy link

Want bw. Needed to change the ordering for SASL Mechanism...

Providers Mailserver seems to report PLAIN and LOGIN. But accepted no PLAIN:
so code failed...

But think its better to ry LOGIN first neither

Want bw. Needed to change the ordering for SASL Mechanism...
@the-djmaze the-djmaze merged commit 98b4910 into the-djmaze:master May 30, 2022
the-djmaze pushed a commit that referenced this pull request May 30, 2022
@akhil1508
Copy link

@the-djmaze This PR's changes cause issues sending emails with SASL login using OAUTHBEARER as the $type that is selected is always set to LOGIN.

Also, it seems to me the changes here basically make sure only the 'LOGIN' type is selected(regardless of what we want to use) always as we check the first possible type and break over here.

@akhil1508
Copy link

akhil1508 commented Dec 14, 2022

@the-djmaze @geraldurbas My suggestion here would be to apply \array_unshift($oSettings->SASLMechanisms, 'LOGIN'); using a beforeLogin hook in a plugin if you want to ensure it gets prioritized and used first in your case.

In any case if the other mechanisms are not supported my your mail server it should default to 'LOGIN' with the change reverted also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants