Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with SMTP login mechanisms except "LOGIN" #774

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

akhil1508
Copy link

Please check comment here

@the-djmaze
Copy link
Owner

Instead of revert, we could also disable SASLMechanisms.
Next release will already have more advanced per Domain setup to set certain IMAP settings there instead of global.

#724 (comment)

@akhil1508
Copy link
Author

akhil1508 commented Dec 14, 2022

@the-djmaze So dropping OAUTHBEARER/XOAUTH2 support entirely? 😢

Or handling it in some other way?

@the-djmaze
Copy link
Owner

the-djmaze commented Dec 14, 2022

I mean, disable PLAIN for #423 and/or disable others as there are more broken IMAP servers between the issues.
As they are external issues, disabling broken SASL mechanisms should solve it.

Then this revert also makes sense without others needing plugins to disable mechanisms

@the-djmaze the-djmaze merged commit 439ad55 into the-djmaze:master Dec 14, 2022
the-djmaze pushed a commit that referenced this pull request Dec 14, 2022
@the-djmaze
Copy link
Owner

the-djmaze commented Dec 14, 2022

Made the change.
As of next release people with issue #693 and #423 can manually modify the sasl parts in data/_data_/_default_/domains/domain.tld.json

{
    "name": "domain.tld",
    "IMAP": {
        "host": "localhost",
        "port": 143,
        "type": 2,
        "timeout": 300,
        "shortLogin": false,
        "sasl": [
            "SCRAM-SHA3-512",
            "SCRAM-SHA-512",
            "SCRAM-SHA-256",
            "SCRAM-SHA-1",
            "PLAIN",
            "LOGIN"
        ],
        "ssl": {
            "verify_peer": true,
            "verify_peer_name": true,
            "allow_self_signed": false,
            "SNI_enabled": true,
            "disable_compression": true,
            "security_level": 1
        },
        "disable_list_status": false,
        "disable_metadata": false,
        "disable_move": false,
        "disable_sort": false,
        "disable_thread": false,
        "use_expunge_all_on_delete": false,
        "fast_simple_search": true,
        "force_select": false,
        "message_all_headers": false,
        "message_list_limit": 0,
        "search_filter": ""
    }
}

And also the "sasl" for SMTP and Sieve

@the-djmaze the-djmaze added the bug Something isn't working label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants