fix/TEC-3232-scheduled-imports #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the main block (if) returns a value inmediatly the subsequent else block is non required plus doing that decrease the mental model around thew flow of the calls on those functions. Task: [TEC-3232]
The functions expect a specifc type of value to be returned but on those instances none was returned (meaning null) in order to keep consistency with the expected value the expected return value was used instead. Task: [TEC-3232]
As if a class, in this particular case: $record is being compared against his parents meaning that if $record is instance of the Tribe__Events__Aggregator__Record__Abstract is the same as comparing that the variable has the class as one of his parents.
Use HOUR_IN_SECONDS constant to present a more meaningful value
A job is empty if has a null_process or is no longer fetching if has an error
Save the last status as failure as well if the job was not successfull
If an error is returned dees not schedule a queue work and mark the job as a failure. Task: [PRMTR-162]
As the default operator of the queries is an AND the queries will remove results that either does not have the key or the value is other than 1 instead the desired behavior is posts where the querie either does not exists or the value is not 1 and where the origin is not CSV.
mitogh
added
code review
Return that was not required as removes the regular flow on the function
Make sure records as pending are pick via the cron job as well Task: [TEC-3232]
|
@mitogh this PR is based on |
|
For now yes we are waiting on a release branch or if are holding the PR, it was based from an old branch as is the one that Loxi is using at the moment. |
borkweb
reviewed
Feb 6, 2020
lucatume
previously approved these changes
Feb 7, 2020
|
@mitogh: I've re-started the tests as it seems a REST API issue not related to the changes. |
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
mitogh
removed
the
needs release
…be/the-events-calendar into fix/TEC-3232-scheduled-imports
bordoni
approved these changes
Feb 7, 2020
bordoni
added
merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all pending jobs are selected when processing the EA Cron
Task: TEC-3232