Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/TEC-3232-scheduled-imports #3052

Merged
merged 24 commits into from Feb 7, 2020
Merged

Commits on Feb 5, 2020

  1. Update array() to the new syntax []

    Task: TEC-3232
    mitogh committed Feb 5, 2020
    Copy the full SHA
    02c4415 View commit details
    Browse the repository at this point in the history
  2. Remove non required else blocks

    As the main block (if) returns a value inmediatly the subsequent else
    block is non required plus doing that decrease the mental model around
    thew flow of the calls on those functions.
    
    Task: [TEC-3232]
    mitogh committed Feb 5, 2020
    Copy the full SHA
    2ce0667 View commit details
    Browse the repository at this point in the history
  3. Add consistent return values

    The functions expect a specifc type of value to be returned but on those
    instances none was returned (meaning null) in order to keep consistency
    with the expected value the expected return value was used instead.
    
    Task: [TEC-3232]
    mitogh committed Feb 5, 2020
    Copy the full SHA
    3965472 View commit details
    Browse the repository at this point in the history
  4. Replacnig in_array with instanceof instead

    As if a class, in this particular case: $record is being compared
    against his parents meaning that if $record is instance of the
    Tribe__Events__Aggregator__Record__Abstract is the same as comparing
    that the variable has the class as one of his parents.
    mitogh committed Feb 5, 2020
    Copy the full SHA
    8d668ff View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    2d327b4 View commit details
    Browse the repository at this point in the history
  6. Replace constant with a more explicit value

    Use HOUR_IN_SECONDS constant to present a more meaningful value
    mitogh committed Feb 5, 2020
    Copy the full SHA
    a90678a View commit details
    Browse the repository at this point in the history
  7. Make sure a job is marked as incomplete if fails

    A job is empty if has a null_process or is no longer fetching if has an
    error
    mitogh committed Feb 5, 2020
    Copy the full SHA
    d253784 View commit details
    Browse the repository at this point in the history
  8. Mark job as failures if an error was present

    Save the last status as failure as well if the job was not successfull
    mitogh committed Feb 5, 2020
    Copy the full SHA
    bb3048b View commit details
    Browse the repository at this point in the history
  9. Remove non used variable

    mitogh committed Feb 5, 2020
    Copy the full SHA
    3fdf56d View commit details
    Browse the repository at this point in the history
  10. Make sure the process of a post does not return error

    If an error is returned dees not schedule a queue work and mark the job
    as a failure.
    
    Task: [PRMTR-162]
    mitogh committed Feb 5, 2020
    Copy the full SHA
    c20f053 View commit details
    Browse the repository at this point in the history
  11. Setup meta query relationships correctly

    As the default operator of the queries is an AND the queries will remove
    results that either does not have the key or the value is other than 1
    instead the desired behavior is posts where the querie either does not
    exists or the value is not 1 and where the origin is not CSV.
    mitogh committed Feb 5, 2020
    Copy the full SHA
    88020eb View commit details
    Browse the repository at this point in the history
  12. Remove non required early return

    Return that was not required as removes the regular flow on the function
    mitogh committed Feb 5, 2020
    Copy the full SHA
    e2227e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Add test for cron job processing records

    Make sure records as pending are pick via the cron job as well
    
    Task: [TEC-3232]
    mitogh committed Feb 6, 2020
    Copy the full SHA
    29c265b View commit details
    Browse the repository at this point in the history
  2. Bypass EA is connected call

    mitogh committed Feb 6, 2020
    Copy the full SHA
    fdcbe70 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Update src/Tribe/Aggregator/Record/Queue_Cleaner.php

    Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
    mitogh and lucatume committed Feb 7, 2020
    Copy the full SHA
    43cf5ee View commit details
    Browse the repository at this point in the history
  2. Update src/Tribe/Aggregator/Record/Queue.php

    Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
    mitogh and lucatume committed Feb 7, 2020
    Copy the full SHA
    edf9d2e View commit details
    Browse the repository at this point in the history
  3. Update src/Tribe/Aggregator/Cron.php

    Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
    mitogh and lucatume committed Feb 7, 2020
    Copy the full SHA
    9c8804f View commit details
    Browse the repository at this point in the history
  4. Update src/Tribe/Aggregator/Cron.php

    Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
    mitogh and lucatume committed Feb 7, 2020
    Copy the full SHA
    6e7d253 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    b7661ee View commit details
    Browse the repository at this point in the history
  6. Merge branch 'fix/TEC-3232-scheduled-imports' of github.com:moderntri…

    …be/the-events-calendar into fix/TEC-3232-scheduled-imports
    mitogh committed Feb 7, 2020
    Copy the full SHA
    1bb16d2 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    3356381 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    ad5e528 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    6f42e0b View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    9eaf274 View commit details
    Browse the repository at this point in the history