New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/TEC-3232-scheduled-imports #3052
Commits on Feb 5, 2020
-
Remove non required else blocks
As the main block (if) returns a value inmediatly the subsequent else block is non required plus doing that decrease the mental model around thew flow of the calls on those functions. Task: [TEC-3232]
-
The functions expect a specifc type of value to be returned but on those instances none was returned (meaning null) in order to keep consistency with the expected value the expected return value was used instead. Task: [TEC-3232]
-
Replacnig in_array with instanceof instead
As if a class, in this particular case: $record is being compared against his parents meaning that if $record is instance of the Tribe__Events__Aggregator__Record__Abstract is the same as comparing that the variable has the class as one of his parents.
-
-
Replace constant with a more explicit value
Use HOUR_IN_SECONDS constant to present a more meaningful value
-
Make sure a job is marked as incomplete if fails
A job is empty if has a null_process or is no longer fetching if has an error
-
Mark job as failures if an error was present
Save the last status as failure as well if the job was not successfull
-
-
Make sure the process of a post does not return error
If an error is returned dees not schedule a queue work and mark the job as a failure. Task: [PRMTR-162]
-
Setup meta query relationships correctly
As the default operator of the queries is an AND the queries will remove results that either does not have the key or the value is other than 1 instead the desired behavior is posts where the querie either does not exists or the value is not 1 and where the origin is not CSV.
-
Remove non required early return
Return that was not required as removes the regular flow on the function
Commits on Feb 6, 2020
-
Add test for cron job processing records
Make sure records as pending are pick via the cron job as well Task: [TEC-3232]
-
Commits on Feb 7, 2020
-
Update src/Tribe/Aggregator/Record/Queue_Cleaner.php
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
-
Update src/Tribe/Aggregator/Record/Queue.php
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
-
Update src/Tribe/Aggregator/Cron.php
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
-
Update src/Tribe/Aggregator/Cron.php
Co-Authored-By: theAverageDev (Luca Tumedei) <luca@theaveragedev.com>
-
Merge branch 'fix/TEC-3232-scheduled-imports' of github.com:moderntri…
…be/the-events-calendar into fix/TEC-3232-scheduled-imports
-
-
-
-