refactor(Controller_Test_Case) #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the `setUp` method to `setUpTestCase` and annotate it with `@before`. Rename the `tearDown` method to `tearDownTestCase` and annotate it with `@after`. Not overriding the base test case `setUp` and `tearDown` methods allows the `Controller_Test_Case` to be use across different PHPUnit versions. Newer versions would require the `: void` return type that older versions will not support.
Camwyn
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
No ticket, born in the context of wp-browser update.
🗒️ Description
Rename the
setUpmethod tosetUpTestCaseand annotate it with@before.Rename the
tearDownmethod totearDownTestCaseand annotate it with@after.Not overriding the base test case
setUpandtearDownmethods allows theController_Test_Caseto be used across different PHPUnit versions.Newer versions would require the
: voidreturn type that older versions will not support.Artifacts
There are no tests covering the
Controller_Test_Casedirectly, but I've run Event Tickets and The Events Calendar tests relying on theController_Test_Caseand did not run into issues.✔️ Checklist
readme.txtfile.wpunitorintegrationtests.wpunitorintegrationtests.