-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo workspace yassin feedback #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Agh...rebasing files I never touched is a pain...🥲 |
@YassinEldeeb why not target my branch? why is it targeted to master? |
|
🐋 This PR was built and pushed to the following Docker images: Docker Bake metadata{
"conductor": {
"containerimage.config.digest": "sha256:8e686644095ed924e63ef55cc02309142af9236b56f1823ecd771ed9302134fd",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"digest": "sha256:2dda9bea5d1cdd50cdd10624b07a5fc107e9d09dac1d27a8afd74fcd2ebebca6",
"size": 901,
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
"containerimage.digest": "sha256:2dda9bea5d1cdd50cdd10624b07a5fc107e9d09dac1d27a8afd74fcd2ebebca6",
"image.name": "ghcr.io/the-guild-org/conductor-t2/conductor:a365171d1bafed7abff120040b7f78cb900d1a47"
}
} |
dotansimha
approved these changes
Nov 19, 2023
dotansimha
added a commit
that referenced
this pull request
Nov 19, 2023
Co-authored-by: Dotan Simha <dotansimha@gmail.com>
dotansimha
added a commit
that referenced
this pull request
Nov 19, 2023
oh, that's the reason...I missed it 😄 Thanks for all the work on landing it!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is applied from @dotansimha's PR?
Tail segments must have names.
warningstrip = false
from CI, since it's defaulted tofalse
async_runtime
crate towasm_polyfills
wasm_polyfills
items inline without imports for better clarity.crates/*
intobin/*
andlibs/*
from_yaml
toparse_config_from_yaml
for better clarity, and extractparse_config_from_json
as a utility as well + reuse those in the main flow.Remove the unusedopenssl
dependency