Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fuzzy matching for marketplace search bar #674

Merged
merged 5 commits into from
Dec 15, 2022
Merged

feat: fuzzy matching for marketplace search bar #674

merged 5 commits into from
Dec 15, 2022

Conversation

YassinEldeeb
Copy link
Member

This adds fuzzy matching to the search bar for marketplace. It helps a lot with catching typos and tryna remembering a plugin name for example in Envelop

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022 •
edited

⚠️ No Changeset found

Latest commit: 9768c8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 9, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
the-guild-components-storybook ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 11:03AM (UTC)

YassinEldeeb
YassinEldeeb commented Dec 9, 2022
View reviewed changes
Copy link
Member Author

@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dimaMachina dimaMachina merged commit 53096ab into the-guild-org:main Dec 15, 2022
@YassinEldeeb YassinEldeeb deleted the fuzzy-matching-search-bar branch December 15, 2022 11:32
andykenward
andykenward reviewed Jan 5, 2023
View reviewed changes
packages/components/src/components/marketplace-search.tsx
@@ -35,18 +36,17 @@ export const MarketplaceSearch = ({
const items = useMemo(() => {
let results = null;
if (query && queryList) {
const tagsFilter = query.split(' ').filter(t => t.trim().length > 1 && t.startsWith('#'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YassinEldeeb & @B2o5T The tag filter search feature no longer works on the envelop plugins page.

See
https://the-guild.dev/graphql/envelop/plugins

CleanShot.2023-01-05.at.22.20.59.mp4

@YassinEldeeb YassinEldeeb mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andykenward andykenward andykenward left review comments

@dimaMachina dimaMachina dimaMachina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YassinEldeeb @andykenward @dimaMachina