Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better prettier plugin for sorting imports #228

Merged
merged 4 commits into from
May 22, 2023

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented May 9, 2023

Now using @ianvs/prettier-plugin-sort-imports.

  • Side-effect imports are not re-ordered (will always stay in the same place)
  • Node.js built in modules are always sorted to the top
  • importOrderCaseInsensitive option has been removed, and imports will always be sorted case-insensitive
  • importOrderSeparation option has been removed, separate groups by adding "" to the importOrder option
  • importOrderSortSpecifiers option has been removed, specifiers are now always sorted

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: 5a0f10a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/prettier-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/eslint-config 0.10.0-alpha-20230522163923-5a0f10a npm ↗︎ unpkg ↗︎
@theguild/prettier-config 1.2.0-alpha-20230522163923-5a0f10a npm ↗︎ unpkg ↗︎
@theguild/tailwind-config 0.2.2-alpha-20230522163923-5a0f10a npm ↗︎ unpkg ↗︎

@enisdenjo
Copy link
Member Author

@B2o5T we good to land this (after rebasing of course)?

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Denis, missed it, let's goooo
image

@enisdenjo enisdenjo force-pushed the better-prettier-sort-plugin branch from 70a14a0 to 5a0f10a Compare May 22, 2023 16:38
@dimaMachina dimaMachina merged commit e899b0c into main May 22, 2023
3 checks passed
@dimaMachina dimaMachina deleted the better-prettier-sort-plugin branch May 22, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants