Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL: add missed translation plus minor fixes #363

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

Faalagorn
Copy link
Contributor

PL: add missed translation plus minor fixes

Description 🗒️

Add one missed translation as well as fix few typos/mistakes I spotted, while also changing the letters to big when it comes to bosses behavior and Health to HP (I think it should be changed in English as well)

Examples 📸

screenshot_2023-02-05-142058
("Class", caliber names in the legend and description can't be translated)
screenshot_2023-02-05-142136
(The behavior and HP should be changed in English as well)

Related Issues 🔗

#175 #362

There are some other missing strings, including most of the page descriptions, boss descriptions, item properties as well as map variant names, month/week names in the graphs and "No options" string in https://tarkov.dev/loot-tier/ as well as select string mention in #362 though I guess I should mention them in a separate issue.


Expand for Help

By submitting this pull request, you agree to our code of conduct

@Faalagorn Faalagorn requested a review from a team as a code owner February 5, 2023 13:25
@Shebuka
Copy link
Contributor

Shebuka commented Feb 5, 2023

There are some other missing strings, including most of the page descriptions, boss descriptions, item properties as well as map variant names, month/week names in the graphs and "No options" string in https://tarkov.dev/loot-tier/ as well as select string mention in #362 though I guess I should mention them in a separate issue.

Can you create an issue with all the places that still miss the translations?

@Shebuka
Copy link
Contributor

Shebuka commented Feb 6, 2023

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: bdc28d3c6825b89b5430ae22741c791fafc80833

@github-actions github-actions bot temporarily deployed to production February 6, 2023 09:28 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Deployment Results ✅

Shebuka successfully deployed branch bdc28d3c6825b89b5430ae22741c791fafc80833 to production

@Shebuka Shebuka merged commit bf6b716 into the-hideout:main Feb 6, 2023
@Faalagorn Faalagorn deleted the patch-2 branch February 6, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants