Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows an error message in case the input search is empty #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lcnogueira
Copy link

An error occurs when the user tries to search for an empty string. So, I've done a small change that shows an error message in this case.

Please, let me know if there is something I can change to make this PR better, @rwieruch.

@lcnogueira lcnogueira changed the title Fixes error when the input search is empty Fixes error in case the input search is empty Dec 25, 2018
@lcnogueira lcnogueira changed the title Fixes error in case the input search is empty Shows an error message in case the input search is empty Dec 25, 2018
@rwieruch
Copy link
Member

Good fix. I think the same applies if the pattern organization/repository is not matched. So the error handling would be a bit more complicated here, and that's why I left it out in the first place because it doesn't really get you any further with actual GraphQL.

@lcnogueira
Copy link
Author

Got it, @rwieruch. Indeed, an error is thrown if the pattern is not matched. Actually, I just wanted to contribute somehow, because I'm not used to sending PR to open source projects 😃. Anyway, thanks for the answer 👍.

@rwieruch
Copy link
Member

Hey @lcnogueira Thanks for contributing in the first place! It really makes sense to dip one's toes into open source :)

I would love to merge the PR, but then I have to adjust the tutorial too. I keep it open for now, because when I revisit my tutorial for this application in 2019, I take your change into account 💯

Wish you all the best!

@lcnogueira
Copy link
Author

Great, @rwieruch. Deal 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants