Skip to content
This repository has been archived by the owner on Jun 12, 2020. It is now read-only.

Fixed camelCase naming typo, and another small typo #35

Closed

Conversation

ShayanJavadi
Copy link

Not much to say as pull request title explains the issue. great book by the way!

@ShayanJavadi ShayanJavadi changed the title fixed naming camelCase issue with setSearchTopstories (setSearchTopstories -> setSearchTopStories ) Fixed camelCase naming typo, and another small typo Mar 14, 2017
@rwieruch
Copy link
Member

rwieruch commented Apr 1, 2017

Hey @ShayanJavadi and thanks for your contribution and praise! I made a single commit to fix the typo: 9604b8d

I wouldn't want to merge the camelCase fix, because it would affect the code in another course that teaches the Road to learn React and might cause confusion when both versions are not in sync. Since it is not bug in the code, I would leave it for now, but I would keep it in mind for the next edition of the book!

@rwieruch
Copy link
Member

rwieruch commented Apr 1, 2017

ref: #40

@rwieruch
Copy link
Member

rwieruch commented Oct 6, 2017

Solved in 3fd4b3e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants