Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Reorganising Collaborating with GitHub chapter into subsections #577

Merged
merged 12 commits into from
May 28, 2019

Conversation

rosiehigman
Copy link
Collaborator

@rosiehigman rosiehigman commented May 28, 2019

Summary

Addresses (but does not close) #468

I've also added the missing screenshot at the bottom of the chapter

List of changes proposed in this PR (pull-request)

  • Chapter split into multiple subsections
  • Added screenshot of GH community profile
  • Updated TOC with new links

What should a reviewer concentrate their feedback on?

  • Do the links work?
  • Is the split in sections logical?
  • Everything looks ok?

Acknowledging contributors

@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for the-turing-way ready!

Built with commit 09e0eed

https://deploy-preview-577--the-turing-way.netlify.com

@rainsworth rainsworth added the book-dash-ldn2019 Issues related to contributions made during the London Book Dash label May 28, 2019
@rosiehigman rosiehigman changed the title [WIP] Reorganising Collaborating with GitHub chapter into subsections [Ready for Review] Reorganising Collaborating with GitHub chapter into subsections May 28, 2019
@rainsworth rainsworth self-requested a review May 28, 2019 12:03
Copy link
Collaborator

@rainsworth rainsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @rosiehigman ! 🎉

@rosiehigman rosiehigman merged commit 4e11c8b into the-turing-way:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-ldn2019 Issues related to contributions made during the London Book Dash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants