-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Restructure Testing chapter #613
Conversation
Deploy preview for the-turing-way ready! Built with commit 0a416af |
Also moved each sentence onto a new line and took out several latin abbreviations
Also separated sentences out onto new lines
Also split each sentence onto a new line
- R unit-tests | ||
- RUnit | ||
- svUnit (works with SciViews GUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add testthat
and tinytest
to the list and remove RUnit
or say it is not recommended.
testthat
is by far the most popular package for R (actually the example of asserting an equality below is done with testthat
) and is actively developed. tinytest
is also being actively developed whereas RUnit
's last release is more than a year old, which triggered some packages to stop using it (i.e. RcppArmadillo).
I was thinking on adding a simple PR for this alone, but I don't want to step on your toes nor difficult this amazing refactoring, so I am fine with you adding the changes directly here if it makes your life easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OriolAbril!
I think this pull request is a little stale (@rosiehigman has a new job!) so I'm not sure who is going to pick this up, so if you wanted to do a little PR then please go for it, but otherwise just leave this comment here so someone can find it again in the future!
@annakrystalli - just tagging you in case you have strong opinions about R testing (I don't know anything John Snow!) @OriolAbril's reasoning makes total sense to me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #760 to change these 2 lines
Summary
Addresses (but does not close) #468
Reformatting to put a new sentence on each line and other similar small fixes
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors