Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVB-2719 Add googletest set-up #64

Merged
merged 5 commits into from Aug 25, 2020
Merged

Conversation

ayan-b
Copy link
Member

@ayan-b ayan-b commented Aug 17, 2020

Closes #57

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #64 into trunk will decrease coverage by 24.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             trunk      #64       +/-   ##
============================================
- Coverage   100.00%   75.31%   -24.69%     
============================================
  Files            1        9        +8     
  Lines           72     1203     +1131     
============================================
+ Hits            72      906      +834     
- Misses           0      297      +297     
Flag Coverage Δ
#cpp 73.74% <ø> (?)
#python 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geodesic_library/geodesic_algorithm_base.h 68.57% <0.00%> (ø)
geodesic_library/geodesic_mesh.h 88.96% <0.00%> (ø)
...odesic_library/geodesic_algorithm_exact_elements.h 56.77% <0.00%> (ø)
geodesic_library/geodesic_algorithm_exact.h 72.06% <0.00%> (ø)
geodesic_library/geodesic_mesh_elements.h 72.72% <0.00%> (ø)
..._library/geodesic_constants_and_simple_functions.h 100.00% <0.00%> (ø)
geodesic_library/geodesic_memory.h 88.23% <0.00%> (ø)
geodesic_library/geodesic_utils.h 93.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a2b99...69aef68. Read the comment docs.

@liadomide liadomide added this to the GSOC2020 milestone Aug 18, 2020
@ayan-b ayan-b changed the title Add googletest set-up [WIP] Add googletest set-up Aug 18, 2020
@ayan-b ayan-b changed the title [WIP] Add googletest set-up Add googletest set-up Aug 24, 2020
@ayan-b ayan-b changed the title Add googletest set-up TVB-2719 Add googletest set-up Aug 24, 2020
Copy link
Member

@liadomide liadomide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage report looks muuch better here! Great job!

Few questions (maybe potential to improve):

@ayan-b
Copy link
Member Author

ayan-b commented Aug 24, 2020

would it be difficult to make this a stand-alone PR, so not top of #49 ?

Done.

Could cpp.ci.sh be moved under https://github.com/the-virtual-brain/tvb-gdist/tree/trunk/packaging ? Maybe rename that entire folder build ?

Thinking about this, as the script itself creates a build directory where tests are performed. We can also rename the packaging folder to something else.

exclude tests/test_geodesic_utils.cpp from the report ?

Done.

@liadomide liadomide merged commit da65c40 into the-virtual-brain:trunk Aug 25, 2020
@ayan-b ayan-b deleted the cpp-test branch August 26, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Code Coverage
2 participants