New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TVB-2719 Add googletest set-up #64
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #64 +/- ##
============================================
- Coverage 100.00% 75.31% -24.69%
============================================
Files 1 9 +8
Lines 72 1203 +1131
============================================
+ Hits 72 906 +834
- Misses 0 297 +297
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage report looks muuch better here! Great job!
Few questions (maybe potential to improve):
- would it be difficult to make this a stand-alone PR, so not top of TVB-2719 Use OpenMP Parallel #49 ?
- Could cpp.ci.sh be moved under https://github.com/the-virtual-brain/tvb-gdist/tree/trunk/packaging ? Maybe rename that entire folder
build
? - exclude
tests/test_geodesic_utils.cpp
from the report ?
Done.
Thinking about this, as the script itself creates a
Done. |
Closes #57