TVB-2719 Use OpenMP Parallel #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayan-b
changed the title
ayan-b
force-pushed
the
parallel
branch
2 times, most recently
from
ce3c1ea
to
d823715
Compare
|
Coverage is not working, not sure why. I would try to fix that in a separate PR. |
liadomide
reviewed
Aug 3, 2020
liadomide
reviewed
Aug 3, 2020
Codecov Report
@@ Coverage Diff @@
## trunk #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 72 51 -21
=========================================
- Hits 72 51 -21
Continue to review full report at Codecov.
|
Closed
liadomide
reviewed
Aug 6, 2020
| * The c++ compiler must have OpenMP installed. This is generally not an issue | ||
| on g++ or Microsoft Visual Studio. However, in macOS one may need to install | ||
| llvm from brew in order to use OpenMP: ``brew install llvm``. Then, change the | ||
| ``CC`` and ``CXX`` environment variables to the following: |
There was a problem hiding this comment.
What is happening when openMP is missing? Can we still use tvb-gdist?
Aren't the openMP pragmas simply ignored?
There was a problem hiding this comment.
They are ignored in g++ and MSVC but not in clang++. The compilation will fail in clang++.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10