-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add help drop downs to primary nav #1659
Comments
You mean like if hovering over the other tabs? Would be nice to access the help faster. |
+1 |
If we do load this dynamically grab the whole tree in one call, not one call for each nested layer. This call can have a medium cache expires like a week. |
OK this is done in repo and is awesome. Dynamically loaded from api call /api/config/articles It was a little bit fiddly because I decided to make sure the the API and article's page called common code to build the article titles structure, which meant refactoring logic out of articles template. |
Awesome I think now I'll flatten those few 3rd level pages, ie move 'bugs' up on level, 'tick types' etc up, and move gyms into it's own top level item, so from now on there is only ever 2 levels. Also thinking I'll make the left menu when inside the articles collapse all submenu items except the one you are in so it's more condensed and the same as index tab. |
Ok got this working much better now, I have completely removed the 'help nav' css and it now uses the exact same css as the main index nav and so is perfectly consistent. In the process I've had a pretty good look through all the articles and not only do I think they need a lot of tlc, but also the structure is all over the shop as we've kept on adding stuff. In particular now that we have only 2 levels I think we need to be slightly more top heavy, ie more top levels and no more than 10 children. 'contributing' is the worst problem one. I'll put down some more thoughts in a new issue |
Do we want to do this dynamically to save bandwidth?
Not urgent, but seems like a better workflow given I am now referring to articles a lot.
The text was updated successfully, but these errors were encountered: