New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor document access #44

Merged

theKashey merged 1 commit into master from query-iframes

Jan 28, 2023

Owner

theKashey commented Jan 28, 2023

followup for #43

Makes usage of document explicit, Simplifies logic which spans over different hosts.


          chore:refactor document access

d6a0046

theKashey commented

View reviewed changes

src/utils/getActiveElement.ts

+                    : activeElement instanceof HTMLIFrameElement && activeElement.contentWindow?.document
+                    ? getActiveElement(activeElement.contentWindow.document)
+                    : activeElement
+                ) as HTMLElement;

Owner Author

theKashey Jan 28, 2023

now there is no need for separate functions to dive deeper - function just shifts from one document to another.

theKashey merged commit 8360af1 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet