Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation messages fixes. #196

Merged
merged 2 commits into from
Sep 15, 2019
Merged

Deprecation messages fixes. #196

merged 2 commits into from
Sep 15, 2019

Conversation

jorgeml
Copy link
Contributor

@jorgeml jorgeml commented Aug 11, 2019

No description provided.

@jorgeml jorgeml changed the title Fixes #180. Deprecation messages fixes. Aug 11, 2019
@jorgeml
Copy link
Contributor Author

jorgeml commented Aug 11, 2019

I haven't tested neither of the changes.

@rshillington
Copy link

For the .RSSLink the updated documentation suggests

{{ with .OutputFormats.Get "rss" -}}
    {{ printf `<link rel="%s" type="%s" href="%s" title="%s" />` .Rel .MediaType.Type .Permalink $.Site.Title | safeHTML }}
{{ end -}}

Could that be a simpler edit for the .RSSLink warning?

@scanepa
Copy link

scanepa commented Sep 13, 2019

For the .RSSLink the updated documentation suggests

{{ with .OutputFormats.Get "rss" -}}
    {{ printf `<link rel="%s" type="%s" href="%s" title="%s" />` .Rel .MediaType.Type .Permalink $.Site.Title | safeHTML }}
{{ end -}}

Could that be a simpler edit for the .RSSLink warning?

Apparently is working with capital RSS, too.

@scanepa
Copy link

scanepa commented Sep 13, 2019

I've run some test and this patch is working for me. When would you merge it?

@budparr
Copy link
Member

budparr commented Sep 15, 2019

Thanks, @scanepa I'll go ahead and merge it.

@budparr budparr merged commit c474ce0 into theNewDynamic:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants