Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an author to blog posts. #209

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Conversation

Beanow
Copy link
Contributor

@Beanow Beanow commented Sep 17, 2019

See #113
This adds an author to the blog page only.
Implementation mostly based on Docsy's version.
https://github.com/google/docsy/blob/master/layouts/blog/content.html

image

Beanow added a commit to teamopen-dev/website-org that referenced this pull request Sep 17, 2019
Beanow added a commit to teamopen-dev/website-org that referenced this pull request Sep 18, 2019
* Draft project lifeguard blogpost.
* Include author till merged upstream.

Upstream PR:
theNewDynamic/gohugo-theme-ananke#209

* Add title dimming. Feedback #6

Co-authored-by: Daniel Thompson-Yvetot <35242872+nothingismagick@users.noreply.github.com>
@budparr
Copy link
Member

budparr commented Sep 28, 2019

Hey, @Beanow I'm basically fine with this. Using author could be problematic, because some may use author for something like a taxonomy lookup, but I think it should be okay.

However, could you wrap the entire p tag in the with statement?

So, instead of

<p class="tracked">
    {{ with .Params.author }}By <b>{{ . | markdownify }}</b>{{ end}}
</p>

use:

{{ with .Params.author }}
    <p class="tracked">
        By <strong>{{ . | markdownify }}</strong>
     </p>
{{ end}}

Co-authored-by: Bud Parr <budparr@gmail.com>
@Beanow
Copy link
Contributor Author

Beanow commented Sep 29, 2019

Would have been happy with you making the change, but here you go 👍

@budparr budparr merged commit 7cb108b into theNewDynamic:master Sep 30, 2019
@Beanow Beanow deleted the pr/blog-author branch September 30, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants