Remove template language from social svg files #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes issues browser issues
Unexpected value {{ . }} parsing height attribute.
|
This should close #454 . |
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
Causes issues browser issues
Unexpected value {{ . }} parsing height attribute.
Co-authored-by: funcsec <github@fsec.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super familiar with Hugo and the templating language, but it appears that the svg files are not parsed and template code that remains is causing browser debug notifications.
The suspect code is not in all of the svg files, missing from twitter and facebook svg's.
Error example:
Unexpected value {{ . }} parsing height attributeGreat theme!