Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display highscores #4

Merged
merged 4 commits into from Oct 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 3 additions & 14 deletions .circleci/config.yml
@@ -1,20 +1,9 @@
# Javascript Node CircleCI 2.0 configuration file
#
# Check https://circleci.com/docs/2.0/language-javascript/ for more details
#
version: 2
jobs:
build:
docker:
# specify the version you desire here
- image: circleci/node:7.10

# Specify service dependencies here if necessary
# CircleCI maintains a library of pre-built images
# documented at https://circleci.com/docs/2.0/circleci-images/
# - image: circleci/mongo:3.4.4

working_directory: ~/repo

steps:
- checkout
- checkout
- run: npm install
- run: npm test
13 changes: 11 additions & 2 deletions README.md
@@ -1,4 +1,13 @@
#RuneHelper
# RuneHelper
Helping people efficiently build their OSRS character

How to run this application:
## Running the app
Clone this repository `git clone git@github.com:theRJMurray/runehelper.git`
`npm install`
`npm start`
In your browser go to localhost:3000/username where username is the
username of the character you want to lookup

## Running tests
`npm install`
`npm test`
18 changes: 12 additions & 6 deletions index.js
@@ -1,15 +1,21 @@
const { constants, hiscores } = require("osrs-api");
const express = require('express')
const app = express()
const axios = require('axios').default;

const port = 3000

var charStats = hiscores.getPlayer({ name: "jZERKk", type: constants.playerTypes.normal })
.then((res) => {
console.log(res.attack)

app.get('/:username', function(req, res, error){
const username = req.params.username
hiscores.getPlayer({ name: username, type: constants.playerTypes.normal })
.then(function (playerData){
res.send(playerData)
})
.catch(function(error){
res.json("An error occurred")
})
})

app.get('/', (req, res) => res.send(charStats))

app.listen(port, () => console.log(`Example app listening on port ${port}!`))

module.exports = app.listen(port)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed so testing is easier