New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display highscores #4
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,9 @@ | ||
# Javascript Node CircleCI 2.0 configuration file | ||
# | ||
# Check https://circleci.com/docs/2.0/language-javascript/ for more details | ||
# | ||
version: 2 | ||
jobs: | ||
build: | ||
docker: | ||
# specify the version you desire here | ||
- image: circleci/node:7.10 | ||
|
||
# Specify service dependencies here if necessary | ||
# CircleCI maintains a library of pre-built images | ||
# documented at https://circleci.com/docs/2.0/circleci-images/ | ||
# - image: circleci/mongo:3.4.4 | ||
|
||
working_directory: ~/repo | ||
|
||
steps: | ||
- checkout | ||
- checkout | ||
- run: npm install | ||
- run: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,13 @@ | ||
#RuneHelper | ||
# RuneHelper | ||
Helping people efficiently build their OSRS character | ||
|
||
How to run this application: | ||
## Running the app | ||
Clone this repository `git clone git@github.com:theRJMurray/runehelper.git` | ||
`npm install` | ||
`npm start` | ||
In your browser go to localhost:3000/username where username is the | ||
username of the character you want to lookup | ||
|
||
## Running tests | ||
`npm install` | ||
`npm test` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,21 @@ | ||
const { constants, hiscores } = require("osrs-api"); | ||
const express = require('express') | ||
const app = express() | ||
const axios = require('axios').default; | ||
|
||
const port = 3000 | ||
|
||
var charStats = hiscores.getPlayer({ name: "jZERKk", type: constants.playerTypes.normal }) | ||
.then((res) => { | ||
console.log(res.attack) | ||
|
||
app.get('/:username', function(req, res, error){ | ||
const username = req.params.username | ||
hiscores.getPlayer({ name: username, type: constants.playerTypes.normal }) | ||
.then(function (playerData){ | ||
res.send(playerData) | ||
}) | ||
.catch(function(error){ | ||
res.json("An error occurred") | ||
}) | ||
}) | ||
|
||
app.get('/', (req, res) => res.send(charStats)) | ||
|
||
app.listen(port, () => console.log(`Example app listening on port ${port}!`)) | ||
|
||
module.exports = app.listen(port) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed so testing is easier