Updated __version__ to 1.1.0 #6
Conversation
…cted refund_amound to refund_amount.
…_code field to Period and BudgetAnalysis types returned by trend_analysis endpoint.
…ponse type of the trend_analysis endpoint. The trend_analysis endpoint returns a singlular BudgetAnalysisPackage type, not a list.
…to ./_overrides/pocketsmith_client.py. When generate-pocketsmith-api.sh is run, it copies ./_overrides/pocketsmith_client.py to ./pocketsmith/.
When the client is generated using the openapi-client-cli, the packageVersion directive is used to set the version reported by the client. >>> import pocketsmith >>> print(pocketsmith.__version__) 1.1.0
|
Holy crap, I think you've learned more about this package than I can remember about it -- and probably more than I ever knew :P I'll be at a keyboard in a few minutes to give this a looksy. P.S. thank you for figuring out how to change the |
|
Okay, I pushed these changes, as well as the User-Agent change, as version 1.2.0 to PyPI. Thank you very much for opening this and other PRs! I really appreciate it, and I'm sure others will benefit from it, too ❤️ |
|
Sorry. I didn’t mean to be pushy. I believed I was required to open a new
PR since I made commits after opening the first PR. I’ll go read up on it.
…On Sun, 11 Jul 2021 at 4:36 am, Zach Kanzler ***@***.***> wrote:
***@***.***Y4Kman* approved this pull request.
lgtm!
I merged the api spec PR, and will update the submodule in a following
commit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4ZE46MTVA6OJ2MB3HBOX3TXCHLDANCNFSM5AD3CDQQ>
.
|
|
idk if that's the proper etiquette, and I don't think you were being pushy; I'm just in the habit of releasing things as quickly as possible, before I forget about them :P Plus, these are tiny projects at the moment, so it's not like there's some well-defined process to adhere to :P You're free to structure your PRs however you see fit. And, incidentally, I found your commit messages very descriptive and your PR body illuminating -- in fact, I was able to craft changelog items directly from it, instead of having to go through the code to dig them out (which I've had to do before). 10/10 PR, would buy again, A+++++++ |
To update version I added the packageVersion=1.1.0 to the openapi-generator-cli call.
I moved changes to ./pocketsmith/pocketsmith_client.py upstream to ./_overrides, where ./generate_pocketsmith_client.sh copies the client source code from.
I re-generated the client with several fixes that are dependant on the pull request to the openapi spec here: theY4Kman/pocketsmith-api-spec#2
Added packageVerrsion=1.1.0 directive to openapi-generator-cli to bake the version into the source code. Now pocketsmith.version returns 1.1.0