Update cmark to 0.28.3.gfm.17 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixonmars
force-pushed
the
update-cmark
branch
2 times, most recently
from
1a98c07
to
27b4af6
Compare
|
Thanks for doing this, @felixonmars, but CI seems very unhappy. |
|
It works fine here with my system cmark-gfm :( Not sure about how I should fix nox. |
|
I'll try to take a look this weekend. We'll need it passing in Travis so we
can build wheels.
…On Fri, Oct 5, 2018 at 12:06 PM Felix Yan ***@***.***> wrote:
It works fine here with my system cmark-gfm :( Not sure about how I should
fix nox.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc4nlrx5dmpxJdSHF26q6ErepeyQ9ks5uh63QgaJpZM4XJ-h2>
.
|
felixonmars
force-pushed
the
update-cmark
branch
from
27b4af6
to
a67da43
Compare
|
I guess I found it - I need to update the generated headers in generated/. The tests are passing now, but unfortunately I don't have a Windows machine so I don't know if I should just copy the headers to windows/ folder too... |
|
I can fix the Windows ones. :)
…On Fri, Oct 5, 2018 at 12:15 PM Felix Yan ***@***.***> wrote:
I guess I found it - I need to update the generated headers in generated/.
The tests are passing now, but unfortunately I don't have a Windows machine
so I don't know if I should just copy the headers to windows/ folder too...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc_7nPWFKCLh-0jzRbCq9dWut8DE5ks5uh6_kgaJpZM4XJ-h2>
.
|
felixonmars
force-pushed
the
update-cmark
branch
from
a67da43
to
338610f
Compare
|
Sorry for the delay here. It seems to be as simple as running |
|
🍰 it passes! Thank you @felixonmars! I'm out of time tonight, so I'll try to cut a release sometime in the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.