[removed] webpack deftool eval-source-map as a redundant optimisation…

… in development mode, which actually made development harder
thealjey · Jan 7, 2016 · 217aa9d · 217aa9d
1 parent 9bc19e2
commit 217aa9d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/docs/JSCompiler.js.html b/docs/JSCompiler.js.html
@@ -269,7 +269,7 @@ <h1 class="page-title">Source: JSCompiler.js</h1>
     const compiler = webpack({
       cache,
       debug: true,
-      devtool: `${this.isProduction ? '' : 'eval-'}source-map`,
+      devtool: 'source-map',
       entry: inPath,
       output: {path: dirname(outPath), filename: basename(outPath)},
       module: {

diff --git a/docs/quicksearch.html b/docs/quicksearch.html
diff --git a/lib/JSCompiler.js b/lib/JSCompiler.js
@@ -281,7 +281,7 @@ var JSCompiler = exports.JSCompiler = function (_Compiler) {
       var compiler = (0, _webpack2.default)({
         cache: cache,
         debug: true,
-        devtool: (this.isProduction ? '' : 'eval-') + 'source-map',
+        devtool: 'source-map',
         entry: inPath,
         output: { path: (0, _path.dirname)(outPath), filename: (0, _path.basename)(outPath) },
         module: {

diff --git a/src/JSCompiler.js b/src/JSCompiler.js
@@ -193,7 +193,7 @@ export class JSCompiler extends Compiler {
     const compiler = webpack({
       cache,
       debug: true,
-      devtool: `${this.isProduction ? '' : 'eval-'}source-map`,
+      devtool: 'source-map',
       entry: inPath,
       output: {path: dirname(outPath), filename: basename(outPath)},
       module: {

diff --git a/test/JSCompiler.spec.js b/test/JSCompiler.spec.js
@@ -71,7 +71,7 @@ describe('JSCompiler', () => {
           expect(webpack).calledWith({
             cache: {},
             debug: true,
-            devtool: 'eval-source-map',
+            devtool: 'source-map',
             entry: '/path/to/the/input/file.js',
             output: {path: '/path/to/the/output', filename: 'file.js'},
             module: {