Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyframe pasting to respect interpolation graph #107

Merged
merged 7 commits into from
Mar 25, 2022

Conversation

vezwork
Copy link
Contributor

@vezwork vezwork commented Mar 24, 2022

Demo

Before the fix:

  1. the curve is slightly horizontally offset from the keyframes
  2. the green y curve is copied from x, but does not match x's curve
  3. the curve does not properly display default values when the keyframe has a type that does not match the track (not pictured)

Screen Shot 2022-03-24 at 4 46 30 PM

after the fix:
  1. the curve is correctly aligned with the keyframes
  2. the green y is copied from x, and does match x
  3. the curve correctly shows default values (not pictured)

Screen Shot 2022-03-24 at 4 50 39 PM

Note

  • also adds 'copy keyframe' to a single keyframe's context menu. Missed this on the first pass.

@vezwork vezwork linked an issue Mar 24, 2022 that may be closed by this pull request
@vezwork vezwork requested a review from AriaMinaei March 24, 2022 20:50
@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for theatrejs-playground ready!

Name Link
🔨 Latest commit 24433fb
🔍 Latest deploy log https://app.netlify.com/sites/theatrejs-playground/deploys/6240d9e2143867335ac4d7cd
😎 Deploy Preview https://deploy-preview-107--theatrejs-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vezwork vezwork requested a review from AriaMinaei March 25, 2022 14:30
@AriaMinaei
Copy link
Member

The ! makes this function's type signature unreliable.

image

theatre/shared/src/propTypes/utils.ts Outdated Show resolved Hide resolved
@vezwork vezwork requested a review from AriaMinaei March 25, 2022 16:53
@AriaMinaei AriaMinaei merged commit 2bf0814 into main Mar 25, 2022
@AriaMinaei AriaMinaei deleted the feature/fix-104-copypaste-keyframes-level branch March 25, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/paste keyframes - level 1
2 participants