"File Prop" Type #408
Merged
"File Prop" Type #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a great PR. Thank you @joaogsleite! I'll review this week. |
|
/release insiders |
🎉 Released an insiders' build to npm. Here is how to upgrade:
--- @theatre/core: "old-version",
+++ @theatre/core: "0.6.1-insiders.4c37567",
--- @theatre/studio: "old-version",
+++ @theatre/studio: "0.6.1-insiders.4c37567",
--- @theatre/dataverse: "old-version",
+++ @theatre/dataverse: "0.6.1-insiders.4c37567",
--- @theatre/react: "old-version",
+++ @theatre/react: "0.6.1-insiders.4c37567",
--- @theatre/browser-bundles: "old-version",
+++ @theatre/browser-bundles: "0.6.1-insiders.4c37567",
--- @theatre/r3f: "old-version",
+++ @theatre/r3f: "0.6.1-insiders.4c37567",
--- theatric: "old-version",
+++ theatric: "0.6.1-insiders.4c37567",All published packages are on npm:
|
|
This looks great! In addition to 3d models we'd love to use this for importing data like CSVs or JSONs. Would love to see this merged! |
AriaMinaei
force-pushed
the
feature/prop-type-file
branch
from
ba3cdfc
to
38e3481
Compare
AriaMinaei
force-pushed
the
feature/prop-type-file
branch
from
38e3481
to
fc849a5
Compare
|
Merged. Thank you @joaogsleite :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already an "Image" Prop Type but it is not possible to select other file types besides images.
With this new "File" Prop Type, it will be possible to select any file type.
Example use case:
Select glb file to change model.