Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getKeyframes method to Sequence #426

Merged
merged 2 commits into from Jul 24, 2023

Conversation

akre54
Copy link
Contributor

@akre54 akre54 commented Jun 12, 2023

Adds the ability to get the keyframes for a given SheetObject prop. Please feel free to tear it apart or modify as you see fit.

Ref #419 (comment)

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
theatre-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 10:23am

@AriaMinaei AriaMinaei enabled auto-merge (squash) July 24, 2023 10:20
@AriaMinaei AriaMinaei disabled auto-merge July 24, 2023 10:26
@AriaMinaei AriaMinaei merged commit 4db16f1 into theatre-js:main Jul 24, 2023
9 checks passed
@AriaMinaei
Copy link
Member

Alright, this one is in. Thank you @akre54! I added a test, and renamed the method to __experimental_getKeyframes() in case we'd need to change its interface later.

@akre54 akre54 deleted the sequence-get-keyframes branch July 24, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants