All prop sequencing #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lator, sanitizer and a value mutator.
Closed
AriaMinaei
requested changes
Oct 25, 2021
| if (typeof defaultValue !== 'number') { | ||
|
|
||
| if ( | ||
| typeof defaultValue !== 'number' && |
There was a problem hiding this comment.
So do we need to explicitly check for a number type here now? Because I think we offloaded that responsibility to the prop types, no?
There was a problem hiding this comment.
I do, as no prop config on the tests.
There was a problem hiding this comment.
I think there is a bug with the tests then, so we should fix this where the tests are defined
theatre/studio/src/panels/DetailPanel/propEditors/ColorPropEditor.tsx
Outdated
Show resolved
Hide resolved
…w done when the value is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sequencing of all prop types, with the ability to override the interpolator. (including compound types, but not supported by the studio yet)
For a value to be sequencable, it needs to either be a number, or implement the functions: Sanitize & Interpolate. which by default, String and Compound types don't do, as I can't interpret the general usage for those types. so I've left it up to the user.
Colours are done using TinyColor2 thanks to Tom for reminding me not only hex colours exist!