Add focus range

[fulopkovacs]

No description provided.

[linear]

THE-110 Focus Range

Description

A way to temporarily focus playback to a certain range

We had this in the older theatre

0d51f4f7-6b30-4ebd-b3f7-b223bd0943cc

Hints

• Ask Aria for how to save the focus' state on the store
• Ask Aria for how to read the state reactively (hint: use usePrism())
• Use the existing context menu hook useContextMenu()
• Find out where in the code, the spacebar key is read. You probably have to read it in your own component, so you can capture those keypresses

[fulopkovacs]

Status: WIP, not ready to merge!

I have reached the point where we have a messy Focus Range with dragable and movable handles for the start and end points of the range. It also controls the playback once you moved the handles AND restarted the playback. I have some thoughts on how to proceed, but a review now would save us a few other ones in the future. 😆 A Slack-huddle/Zoom call would be appreciated, since I have a few questions.

[AriaMinaei]

Looks like the drag gesture has a drift in FF depending on zoom level, but not in Chrome.

Screenflick.Movie.68.mp4

[netlify]

❌ Deploy Preview for theatrejs-playground failed.

Name	Link
🔨 Latest commit	6bafdf6
🔍 Latest deploy log	https://app.netlify.com/sites/theatrejs-playground/deploys/623de2aac3718f0009b9f23d

[fulopkovacs]

Current state of the PR:

• fix the height of the highlighted part of the DopeSheet
• minimal size
• double click for max size
• replace the current color of focusRangeStrip when dragging
• replace the current color of focusRangeThumb when dragging
• make the playhead bigger when the focusRange is used for the playback
• [bugfix] Don't highlight the range on hover when it's disabled
• [feature] display tooltips above the focusRangeThumb-s when dragging
• [bugfix] fix the visuals of the playhead (it looks bad when it's scaled up)
• [refactor] remove the "double click to expand" feature (Mariusz approved this)
• [refactor] refactor the focusRangeTheme object
• [refactor] review and clean up the PR

[AriaMinaei]

This is great! Just a couple suggestions:

1. Review the code comments and comment anything that's not obvious (like sequence.playInDynamicRange()
2. Make the thumbs snappable.

[fulopkovacs]

Current status after the 1st review:

• Make the thumbs snapable
• Add comments to the parts that are harder to read