feat: jest tests #140
Merged
feat: jest tests #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotsi
force-pushed
the
feat/jest-tests
branch
from
40ce37f
to
bdac37d
Compare
mikehardy
requested changes
Nov 19, 2021
mikehardy
requested changes
Nov 19, 2021
There was a problem hiding this comment.
The CI addition is fantastic, and the single jest setup line is fantastic
I left a note on including it in the released module, that's important :-)
I'm still confused about the eslint integration - I just don't understand that. We don't have to block the PR on it but if I can't understand it I would at least like a comment in there that has the URL to this discussion and a note "this may not be necessary?"
So the package.json change is the blocker, the eslint thing I'd like to understand but could let it go
mikehardy
approved these changes
Nov 19, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2021
# [6.1.0](v6.0.0...v6.1.0) (2021-11-19) ### Features * **test:** add jest tests and mock file for library users ([#140](#140)) ([cc904e7](cc904e7))
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys! Recently I needed to create some mocks for this lib, so I'm bringing this to the lib to help others that want to do the same.
These are the features from this PR:
1 - Configure Jest
2 - Create a mock folder with
AppEventParamsandAppEventsto make a more faithful mock, as this content came from the Native we can't access this withAppEventsLogger.AppEventson Jest, that's why I'm putting this on the mocks folder.3 - Update readme with a basic example module.