fix: adjust import and jest eslint env #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikehardy can you check this? |
mikehardy
approved these changes
Nov 22, 2021
| @@ -1,4 +1,6 @@ | |||
| const nonMocked = require('../../lib/commonjs'); | |||
| /* eslint-env jest */ | |||
There was a problem hiding this comment.
Oh dang! We got it one spot https://github.com/thebergamo/react-native-fbsdk-next/pull/140/files#diff-759a02c8fa99d555891bb2a2d3ae2495a2295dc1e1183dc8ba6281b0e172208aR1
but missed this one. Nice catch
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2021
## [6.1.1](v6.1.0...v6.1.1) (2021-11-22) ### Bug Fixes * **test:** adjust import and jest eslint env ([#144](#144)) ([be213b0](be213b0))
|
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! After this merge I tried to update the lib and use the mocks but I'm getting the following error:
So I change the import to the component itself like react-native-permission does and started working on the app.
Also, I'm adding the
/* eslint-env jest */to avoid eslint error on this file (didn't see this on the first PR)