Fixes #131
Merged
Fixes #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igger Fix: Metronome - Task stopped in more places to ensure pad quickfade works (another case of it affecting another async task!) - with associated rework Fix: Metronome and Pad Autostart for all song types Fix: PDF page turn keeps running pads etc by use of loadsong in reloadSong mode Change: Stagemode vibrates only on button use (not on gestureX call)
…UTOR' improving stability - no longer uses 'AsyncTask.THREAD_POOL_EXECUTOR' which alleviates risk of delay to song loads, pads, etc. when Metronome is running (observed on Android 9 but not Android 5!)
…READ_POOL_EXECUTOR) - Visual Metronome changed to start with first sound beat
…00/0:00 for some cases
…wse elsewhere which was causing reload fail (the same approach as openFragment) - particularly needed for PDF when page turn is a reload and a fail shows page 0! Other: Minor Popup code changes
Fix: PDF load fail adds 'That song isn't on your device...' as author line
- makePDf calls are only made if SQLite returns a song (it fails otherwise) - For set export, PDF and Img files are exported as-is when using 'OpenSongApp song (.ost)' / 'Desktop file (no extension)' - to provide a means to export these files
Fix: Presenter mode selectSectionButtonInSong changed to support PDF and Image files
…ng quick navigate buttons
Fix: Clear of views before display of PDF/Img (no previous content!) in presentation mode Fix: Nearby - a delete file wrapped in a try as was failing and blocking song change in some cases Fix: 'incomingchange' mechanism needed to be reset by a file load too
…y only for 'Stage' mode.
- Toast message for a large file transfer - Added cancel of any older running transfers on change of song to stop delays - PDF and Image files are sent to all clients (was just one)
…cted to client - getPDFPageCount call moved
- A slow FILE song transfer could display after a newer song has displayed - these transfers are now cancelled on Host and Clients (cancelTransferIds etc) - An arriving FILE must be for the most recent BYTE foldernamepair or it is abandoned
…ong details in the BYTES 'FILE:' transfer and abandon the FILE transfers as not needed. This reduces HOST and CLIENT work load.
|
Really happy with the big improvements for Nearby large FILE: transfer - code cancels old FILE transfers when a new song is sent or all when not 'receive host files'. Less work for host and client, quick song changes and only one full FILE transfer when needed. Result! Makes it much more usable for PDFs with a few page - no 4M photos please! |
thebigg73
added a commit
that referenced
this pull request
Sep 19, 2021
|
I just added a change to my fork so that Nearby OFF is actually OFF. You
might like to manually add. Only a few ifs added.
Kind regards
Ian
…On Sunday, 19 September 2021, Gareth Evans ***@***.***> wrote:
Merged #131 <#131> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLL3SYCNUM5BZO7OHCKTMDUCZJ4DANCNFSM5DVVR43Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit notes
Hello Gareth.
This includes more places where PDF and image handling needs amending and more places where widening of actions to all song types is needed. Doh. A fix for Metronome overloading the async task thread pool and a major fix and performance improvement for for Nearby too!
Kind regards
Ian