Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ProgressIndicator in DynamicIsland from struct to final class #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

helloworldjay
Copy link

@helloworldjay helloworldjay commented Feb 11, 2023

Hi!
Thx for your awesome codes for Dynamic Island :]

I just figured it out that it's better to change ProgressIndicator which is implemented in extension DynamicIsland.
Since the property progressIndicator is declared as let property which is struct, it's impossible to allocate new values for properties in progressIndicator as README.md you wrote.

image

We can make progressIndicator var as well, but I thought this way is better(But it's your call of course!).

I hope it's not my misunderstanding and can help u even though it's just a little thingy ☺️

Plz let me know if there are any changes you need more or this PR is not needed.
Thx again!

README.md

A simple object that provides access to a progress indicator around the Dynamic Island cutout.
To use it, simply access DynamicIsland.progressIndicator from anywhere to control the indicator.

DynamicIsland.progressIndicator.progressColor = .green
DynamicIsland.progressIndicator.isProgressIndeterminate = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant