Change ProgressIndicator in DynamicIsland from struct to final class #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thx for your awesome codes for Dynamic Island :]
I just figured it out that it's better to change
ProgressIndicator
which is implemented inextension DynamicIsland
.Since the property
progressIndicator
is declared as let property which is struct, it's impossible to allocate new values for properties inprogressIndicator
as README.md you wrote.We can make
progressIndicator
var as well, but I thought this way is better(But it's your call of course!).I hope it's not my misunderstanding and can help u even though it's just a little thingy☺️
Plz let me know if there are any changes you need more or this PR is not needed.
Thx again!
README.md