fix: typescript definition for PlainChildren #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new tsconfig for the build task. This ensures tsc is run on all files in the project, while we still only emit the files in 'src'
etripier
approved these changes
Mar 25, 2019
|
|
||
| /** Call this function whenever the in view state changes */ | ||
| onChange?: (inView: boolean, entry: IntersectionObserverEntry) => void | ||
| } & React.HTMLProps<HTMLDivElement> | ||
| } & Omit<React.HTMLProps<HTMLElement>, 'onChange'> |
johnrackles
pushed a commit
to johnrackles/react-intersection-observer
that referenced
this pull request
Feb 19, 2020
Create a new tsconfig for the build task. This ensures tsc is run on all files in the project, while we still only emit the files in 'src'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on improving the types for
PlainChildren- See #202Create a new tsconfig for the build task. This ensures
tscis run on all files in the project,while we still only emit the files in 'src'