Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/staticfilemanager refactor #53

Merged
merged 7 commits into from May 10, 2020

Commits on May 7, 2020

  1. Configuration menu
    Copy the full SHA
    51a60b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    004e20d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47af7a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    14923fb View commit details
    Browse the repository at this point in the history
  5. Refactor initialization and error handling

    - Get rid of all properties as they were actually non needed.
    - The route block is setup on init.
    - Error creation is centralized.
    thecatalinstan committed May 7, 2020
    Configuration menu
    Copy the full SHA
    af11f5d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Split monolithic static file serving logic

    The goal is to avoid a large number of blocks being created as a result of each request. The initial "hasty" implementation created and called route blocks for every request, which was a bit overkill and wasteful.
    
    The new implementation has only one route block being create on `init` and calls instance methods for various tasks. This results in a simplified, more readable and a more efficient logic.
    thecatalinstan committed May 10, 2020
    Configuration menu
    Copy the full SHA
    db4869a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c095eda View commit details
    Browse the repository at this point in the history