Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using colorable to support Windows #32

Closed
wants to merge 1 commit into from
Closed

Conversation

OtisOat
Copy link

@OtisOat OtisOat commented Aug 26, 2021

Utilizing go-colorable to change the default writer to support color printing in both stopFail and stopFailColors

Utilizing go-colorable to change the default writer to support color printing in both `stopFail` and `stopFailColors`
@theckman
Copy link
Owner

@OtisOat apologies for the delay, I somehow missed the GH notification for this PR. Would you be able to rebase / resolve conflicts?

I've converted this to a Go Module, so you'll probably need to go mod tidy after rebasing.

theckman added a commit that referenced this pull request Dec 11, 2021
This change adds a direct dependency on `github.com/mattn/go-colorable` to
support Windows terminals, and removes the plumbing that hardcodes Windows as a
dumb terminal.

Closes #32
theckman added a commit that referenced this pull request Dec 11, 2021
This change adds a direct dependency on `github.com/mattn/go-colorable` to
support Windows terminals, and removes the plumbing that hardcodes Windows as a
dumb terminal.

This is inspired by #32 opened by @OtisOat.

Closes #32
@theckman
Copy link
Owner

theckman commented Dec 11, 2021

@OtisOat I did some more looking at this, and realized there would be some other needed changes before this could be merged (even after resolving conflicts). So I opened a similar PR (#39) and will move that one forward to release v0.10.0.

@theckman theckman closed this in e5c32e2 Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants